Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background color on title bar sometimes makes favicons hard to view #16

Closed
heliostatic opened this issue Jan 30, 2011 · 3 comments
Closed

Comments

@heliostatic
Copy link
Contributor

In a few cases, the background color on the title bar makes site favicons hard to view: https://img.skitch.com/20110130-jarpkg7grrtkbstb3ksjiuk43x.jpg

@samuelclay
Copy link
Owner

I think that's the point. It's a really, really cool feature, but it's also a completely new way to think about styling these things. I don't think I've ever seen another program create gradient bars based on the dominant color of a favicon/image. I think because I'm trying to hit that dominant color so prominently, icons that are of only one color are going to show up a bit muted against the gradient.

Now, I tried to account for this effect by making the gradient span 35 pixels from dominant color to a brighter hue. That means the icon should show up as a bit darker than the background gradient, which it appears to be doing.

Try it out and see if it still bothers you. I think the effect of having the icon blend in with the background is negated by the fact that the icon is also present on the left sidebar, and kinda shows through the gradient.

@heliostatic
Copy link
Contributor Author

I do really like the feature, but when some icons get lost and others don't, it is a little distracting:

https://img.skitch.com/20110201-cjh3m95n8w9a3fyranukmntgpf.png

Overall, the addition of color is really beautiful.

@heliostatic
Copy link
Contributor Author

Final update: I'm a convert. The color bar is useful, usable and pretty.

sictiru added a commit that referenced this issue Oct 28, 2022
Reorganize Android project file structure for Android Studio.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants