-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No exception on job timeout #247
Comments
I think If you want to do something different, you might be able to catch it inside the job? |
Inside the job there is |
Humm, the the logic I implemented was copied from async-timeout, so I would have expected the behaviour to be the same. Guess I'm wrong... |
https://github.com/aio-libs/async-timeout/blob/master/async_timeout/__init__.py#L191-L194 |
Oh, missed that. Happy to accept a PR if we can fix it. |
Is it ok to just return |
yes, we need access to the task to add it to |
For stuff like this, it's worth reading the code rather than asking questions, it's relatively clear in the code: |
Actually inside a job it's always been |
Humm, I think we should revert this to just log the error, you can always catch the Would you create a PR? |
* Fix jobs timeout #247 * Bump codecov-action to v1.5.2 * Fix test Co-authored-by: Kirill Matveev <kirill.matveev@akvelon.com>
* Fix jobs timeout python-arq#247 * Bump codecov-action to v1.5.2 * Fix test Co-authored-by: Kirill Matveev <kirill.matveev@akvelon.com>
This seems to have been resolved. |
In v0.20 when job is timed out
asyncio.TimeoutError
is not raised. Instead there is log message:job_name cancelled, will be run again
and job is restarted immediately.Is it intentional? Having some exception on timeout and allow app to decide how to handle it seems more appropriate to me.
The text was updated successfully, but these errors were encountered: