Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat Add IsIP #43

Merged
merged 2 commits into from Aug 25, 2022
Merged

feat Add IsIP #43

merged 2 commits into from Aug 25, 2022

Conversation

osintalex
Copy link
Contributor

Here's a stab at IsIP.

I'm not sure how useful the netmask keyword argument is but thought I'd include it so you can see. Should be easy to take it out if you don't think it's a good idea.

@codecov
Copy link

codecov bot commented Jun 12, 2022

Codecov Report

Merging #43 (004bf82) into main (593bccc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          666       690   +24     
  Branches       167       174    +7     
=========================================
+ Hits           666       690   +24     
Impacted Files Coverage Δ
dirty_equals/__init__.py 100.00% <100.00%> (ø)
dirty_equals/_other.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 593bccc...004bf82. Read the comment docs.

Copy link
Owner

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

dirty_equals/_other.py Outdated Show resolved Hide resolved
dirty_equals/_other.py Outdated Show resolved Hide resolved
dirty_equals/_other.py Outdated Show resolved Hide resolved
@samuelcolvin
Copy link
Owner

let me know when this is ready to review.

@osintalex
Copy link
Contributor Author

It's ready for review ☺️

@samuelcolvin samuelcolvin merged commit 928a732 into samuelcolvin:main Aug 25, 2022
@samuelcolvin
Copy link
Owner

thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants