Change return type hint for create_model (#526)

* Change return type hint for create_model, fix #525 * remove unnecessary ignore * Update HISTORY.rst
pydantic · May 16, 2019 · 9b98d14 · 9b98d14
1 parent fe72ba1
commit 9b98d14
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -7,6 +7,7 @@ v0.26 (unreleased)
 ..................
 * fix to schema generation for ``IPvAnyAddress``, ``IPvAnyInterface``, ``IPvAnyNetwork`` #498 by @pilosus
 * fix variable length tuples support, #495 by @pilosus
+* fix return type hint for ``create_model``, #526 by @dmontagu
 
 v0.25 (2019-05-05)
 ..................

diff --git a/pydantic/main.py b/pydantic/main.py
@@ -526,7 +526,7 @@ def create_model(  # noqa: C901 (ignore complexity)
     __module__: Optional[str] = None,
     __validators__: Dict[str, classmethod] = None,
     **field_definitions: Any,
-) -> BaseModel:
+) -> Type[BaseModel]:
     """
     Dynamically create a model.
     :param model_name: name of the created model
@@ -571,7 +571,7 @@ def create_model(  # noqa: C901 (ignore complexity)
     if __config__:
         namespace['Config'] = inherit_config(__config__, BaseConfig)
 
-    return type(model_name, (__base__,), namespace)  # type: ignore
+    return type(model_name, (__base__,), namespace)
 
 
 def validate_model(  # noqa: C901 (ignore complexity)