Fix argument name collision #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1367 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 3723 3723
Branches 735 735
=========================================
Hits 3723 3723
Continue to review full report at Codecov.
|
|
LGTM, I'll do my best to get this merged when I next have time to go through PRs. |
|
thanks so much, sorry again for the delay. |
jaheba
added a commit
to jaheba/gluon-ts
that referenced
this pull request
Apr 19, 2020
Fixes awslabs#767 The `model_name` argument was renamed to `__model_name` in [pydantic/pydantic#1367. This change ensure that our code works with both future and past versions of pydantic.
jaheba
added a commit
to jaheba/gluon-ts
that referenced
this pull request
Apr 19, 2020
Fixes awslabs#767 The `model_name` argument was renamed to `__model_name` in [1367](pydantic/pydantic#1367). This change ensure that our code works with both future and past versions of pydantic.
jaheba
added a commit
to awslabs/gluonts
that referenced
this pull request
Apr 19, 2020
Fixes #767 The `model_name` argument was renamed to `__model_name` in [1367](pydantic/pydantic#1367). This change ensure that our code works with both future and past versions of pydantic.
lostella
pushed a commit
to lostella/gluonts
that referenced
this pull request
Apr 23, 2020
Fixes awslabs#767 The `model_name` argument was renamed to `__model_name` in [1367](pydantic/pydantic#1367). This change ensure that our code works with both future and past versions of pydantic.
lostella
added a commit
to awslabs/gluonts
that referenced
this pull request
Apr 23, 2020
* Fix pydanitc `create_model` usage. (#768) Fixes #767 The `model_name` argument was renamed to `__model_name` in [1367](pydantic/pydantic#1367). This change ensure that our code works with both future and past versions of pydantic. * fix style according to black==19.3b0 Co-authored-by: Jasper Schulz <schjaspe@amazon.de>
KimHeecheola
added a commit
to KimHeecheola/gluon-ts
that referenced
this pull request
Nov 12, 2022
Fixes #767 The `model_name` argument was renamed to `__model_name` in [1367](pydantic/pydantic#1367). This change ensure that our code works with both future and past versions of pydantic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Renaming
model_nameargument ofmain.create_model()to__model_nameto allow usingmodel_nameas a field name.Related issue number
#1366
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)