Add a TypedDict class for error objects #3038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds more specific typing for the dictionaries in `ValidationError.errors()`. This shouldn't introduce any functional change.
matthewhughes934
force-pushed
the
add-typeddict-for-error-object
branch
from
21115ea
to
5480849
Compare
|
please review |
PrettyWood
force-pushed
the
add-typeddict-for-error-object
branch
from
f7d4527
to
7871e84
Compare
jpribyl
pushed a commit
to liquet-ai/pydantic
that referenced
this pull request
Oct 7, 2021
* Add a TypedDict class for error objects This adds more specific typing for the dictionaries in `ValidationError.errors()`. This shouldn't introduce any functional change. * quotes * split required and not required keys * type but be a class * workaround cython (can't wait for v3) Co-authored-by: PrettyWood <em.jolibois@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This adds more specific typing for the dictionaries in
ValidationError.errors(). This shouldn't introduce any functionalchange.
Related issue number
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)