rename allow_population_by_alias -> allow_population_by_field_name #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 2716 2716
Branches 518 518
=====================================
Hits 2716 2716Continue to review full report at Codecov.
|
|
Looks good to me! Out of curiosity -- do you have a timeline in mind for when the "deprecated" warning will become an error? |
Not really, I didn't really want to add them to v1, but @tiangolo asked me to include them. Perhaps 4 months or v1.2 whichever takes longer? |
dmontagu
approved these changes
Oct 7, 2019
andreshndz
pushed a commit
to cuenca-mx/pydantic
that referenced
this pull request
Jan 17, 2020
…ydantic#875) * rename allow_population_by_alias -> allow_population_by_field_name, fix pydantic#585 * add change * tweak PR template ☣️ * tweak Makefile
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue number
fix #585
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)