Adding deque to valid field types #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wozniakty
force-pushed
the
field-type-deque
branch
3 times, most recently
from
cde07ab
to
1b64b31
Compare
Codecov Report
@@ Coverage Diff @@
## master #1935 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 21 21
Lines 4003 4021 +18
Branches 799 804 +5
=======================================
+ Hits 3999 4017 +18
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
wozniakty
force-pushed
the
field-type-deque
branch
2 times, most recently
from
efd3395
to
9cc3cbd
Compare
samuelcolvin
reviewed
Oct 9, 2020
|
you'll also need to resolve conflicts. |
wozniakty
force-pushed
the
field-type-deque
branch
from
9cc3cbd
to
a29a664
Compare
wozniakty
force-pushed
the
field-type-deque
branch
from
570834a
to
527f480
Compare
|
@samuelcolvin updated, thanks for the input 👍 this PR gave me a lot more context on how pydantic works, was fun to work on |
PrettyWood
requested changes
Oct 9, 2020
Co-authored-by: PrettyWood <em.jolibois@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Got bored so I PR'd an issue from @hongquan:
Adding deque as a valid sequence type for fields
Related issue number
Closes #1934
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)