Add a frozenset type annotation to allowed_schemes on stricturl

[Midnighter]

Change Summary

I was recently using the stricturl field type and declared some constants for the allowed schemes. Semantically, it makes the most sense to me to use frozensets for those constants. Thus I propose to extend the type annotation to include FrozenSet[str].

Checklist

• Unit tests for the changes exist
• Tests pass on CI and coverage remains at 100%
• Documentation reflects the changes where applicable
• changes/<pull request or issue id>-<github username>.md file added describing change
  (see changes/README.md for details)

Locally, the test suite fails for me with

pydantic/main.py:367:5: C901 'BaseModel.__setattr__' is too complex (15)

but that's unrelated to my change.

[codecov]

Codecov Report

Merging #2198 (6123b55) into master (13a5c7d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2198   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         4199      4199           
  Branches       854       854           
=========================================
  Hits          4199      4199           

Impacted Files	Coverage Δ
pydantic/networks.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13a5c7d...6123b55. Read the comment docs.

[PrettyWood]

LGTM!
For the local error on make lint, it's because you must be using python 3.7- version.
The check is done on the line with the decorator (l367) whereas with python 3.8+ it's the decorated one that is (l368)
https://github.com/samuelcolvin/pydantic/blob/1a2791d4223ff1d18400432ef5d020ce6910aa4a/pydantic/main.py#L367-L368
We could probably just add a second # noqa: C901 on l367 like it's done above
https://github.com/samuelcolvin/pydantic/blob/1a2791d4223ff1d18400432ef5d020ce6910aa4a/pydantic/main.py#L211-L212

[Midnighter]

You are correct. I had messed up something with my virtualenvs. Tests all pass in a fresh new 3.8 environment.

[samuelcolvin]

LGTM, please add a change description.

[Midnighter]

LGTM, please add a change description.

Sorry, I already had this locally but failed to push it. It's in now.

[PrettyWood]

LGTM!

[samuelcolvin]

thanks a lot.