improving schema #232
Merged
improving schema #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
force-pushed
the
schema-take-2
branch
from
c082e26
to
40d06b6
Compare
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 1396 1416 +20
Branches 257 264 +7
=====================================
+ Hits 1396 1416 +20 |
|
@Gr1N let me know what you think. I believe this is ready to be released. I'm away on holiday from the end of today until the 30th of July, so will probably need to wait until then to release. |
Gr1N
reviewed
Jul 23, 2018
| 'item_types': [sf.type_schema(by_alias) for sf in self.sub_fields], | ||
| } | ||
| else: | ||
| assert self.shape is Shape.SINGLETON, self.shape |
There was a problem hiding this comment.
Do we really want to use asserts in production code?
|
Tested in my projects, it's great! Have a good holidays! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #213