Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ClassVar, #339

Merged
merged 2 commits into from Dec 27, 2018
Merged

support ClassVar, #339

merged 2 commits into from Dec 27, 2018

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Dec 27, 2018

Change Summary

exclude attributes annotated with ClassVar from fields

Related issue number

fix #184

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes
  • No performance deterioration (if applicable)
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • if you're not a regular contributer please include your github username @whatever

@codecov
Copy link

codecov bot commented Dec 27, 2018

Codecov Report

Merging #339 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #339   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines        1805   1808    +3     
  Branches      352    353    +1     
=====================================
+ Hits         1805   1808    +3

@samuelcolvin
Copy link
Member Author

I guess if we were perfect we'd add a section to documentation on this, but for now I can't be bothered.

@samuelcolvin samuelcolvin merged commit c2bae0a into master Dec 27, 2018
@samuelcolvin samuelcolvin deleted the class-vars branch December 27, 2018 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class variables?
1 participant