Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for 'missing' error with validate_all or validate_always #381

Merged
merged 3 commits into from Feb 4, 2019

Conversation

@samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Jan 30, 2019

Change Summary

Fix model parsing behaviour when validate_all=True or validate_always=True to raise the correct error.

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>
@codecov
Copy link

@codecov codecov bot commented Jan 30, 2019

Codecov Report

No coverage uploaded for pull request base (master@9ef4018). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff           @@
##             master   #381   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     14           
  Lines             ?   1895           
  Branches          ?    369           
=======================================
  Hits              ?   1895           
  Misses            ?      0           
  Partials          ?      0

@samuelcolvin samuelcolvin merged commit 04391da into master Feb 4, 2019
6 of 8 checks passed
@samuelcolvin samuelcolvin deleted the validate_model-missing-fix branch Feb 4, 2019
@samuelcolvin samuelcolvin mentioned this pull request Mar 5, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant