Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the build reproducible #805

Conversation

lamby
Copy link
Contributor

@lamby lamby commented Sep 13, 2019

Whilst working on the Reproducible Builds effort we noticed that pydantic could not be built reproducibly. This is due to it generating the contents of the PKG-INFO file via iterating over the contents of a set.

This was originally filed in Debian as #940156.

Whilst working on the Reproducible Builds effort [0] we noticed
that pydantic could not be built reproducibly.

This is due to it generating the contents of the `PKG-INFO` file
via iterating over the contents of a set.

This was originally filed in Debian as #940156 [1].

 [0] https://reproducible-builds.org/
 [1] https://bugs.debian.org/940156

Signed-off-by: Chris Lamb <lamby@debian.org>
@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #805 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #805   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     17           
  Lines        2851   2851           
  Branches      560    560           
=====================================
  Hits         2851   2851

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7704ff8...6499538. Read the comment docs.

@samuelcolvin samuelcolvin merged commit ef894d2 into pydantic:master Sep 13, 2019
@samuelcolvin
Copy link
Member

thanks a lot, merged.

Is there somewhere I can check that pydantic is compliant with reproducible-builds.org, or documentation on what you did to build pydantic and notice this?

Or do you just a a script that runs python setup.py build and checks the hash of the artefacts?

@lamby
Copy link
Contributor Author

lamby commented Sep 14, 2019

Is there somewhere I can check that pydantic is compliant with reproducible-builds.org, or documentation on what you did to build pydantic and notice this?

Sure, I suggest you start here for our automated tests that run against the Debian packages:

https://tests.reproducible-builds.org/debian/pydantic

:)

@lamby lamby deleted the 940156-pydantic-please-make-the-build-reproducible branch September 14, 2019 09:00
alexdrydew pushed a commit to alexdrydew/pydantic that referenced this pull request Dec 23, 2023
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants