Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the build reproducible #805

Conversation

@lamby
Copy link
Contributor

commented Sep 13, 2019

Whilst working on the Reproducible Builds effort we noticed that pydantic could not be built reproducibly. This is due to it generating the contents of the PKG-INFO file via iterating over the contents of a set.

This was originally filed in Debian as #940156.

Whilst working on the Reproducible Builds effort [0] we noticed
that pydantic could not be built reproducibly.

This is due to it generating the contents of the `PKG-INFO` file
via iterating over the contents of a set.

This was originally filed in Debian as #940156 [1].

 [0] https://reproducible-builds.org/
 [1] https://bugs.debian.org/940156

Signed-off-by: Chris Lamb <lamby@debian.org>
@codecov

This comment has been minimized.

Copy link

commented Sep 13, 2019

Codecov Report

Merging #805 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #805   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     17           
  Lines        2851   2851           
  Branches      560    560           
=====================================
  Hits         2851   2851

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7704ff8...6499538. Read the comment docs.

@samuelcolvin samuelcolvin merged commit ef894d2 into samuelcolvin:master Sep 13, 2019
7 of 10 checks passed
7 of 10 checks passed
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/project 100% remains the same compared to 7704ff8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
samuelcolvin.pydantic Build #20190913.1 succeeded
Details
samuelcolvin.pydantic (Job Python36) Job Python36 succeeded
Details
samuelcolvin.pydantic (Job Python37) Job Python37 succeeded
Details
@samuelcolvin

This comment has been minimized.

Copy link
Owner

commented Sep 13, 2019

thanks a lot, merged.

Is there somewhere I can check that pydantic is compliant with reproducible-builds.org, or documentation on what you did to build pydantic and notice this?

Or do you just a a script that runs python setup.py build and checks the hash of the artefacts?

@lamby

This comment has been minimized.

Copy link
Contributor Author

commented Sep 14, 2019

Is there somewhere I can check that pydantic is compliant with reproducible-builds.org, or documentation on what you did to build pydantic and notice this?

Sure, I suggest you start here for our automated tests that run against the Debian packages:

https://tests.reproducible-builds.org/debian/pydantic

:)

@lamby lamby deleted the lamby:940156-pydantic-please-make-the-build-reproducible branch Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.