Email tweaks #988
Merged
Email tweaks #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
added
the
deferred
Codecov Report
@@ Coverage Diff @@
## master #988 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 19 19
Lines 3287 3286 -1
Branches 650 650
=====================================
- Hits 3287 3286 -1
Continue to review full report at Codecov.
|
samuelcolvin
force-pushed
the
email-tweaks
branch
from
85e9fb1
to
e5f8082
Compare
graue70
reviewed
Mar 1, 2021
samuelcolvin
commented
Aug 4, 2022
hramezani
reviewed
Sep 7, 2022
hramezani
reviewed
Sep 7, 2022
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Some small and subtle tweaks to email validation. This will probably need to wait until v2 to be released.
As far as I know the following things have changed (but
email-validator's tests aren't that clear, so I could be wrong):' Fred Smith <fred@example.com>'the name would now be'Fred Smith', before it would have been' Fred Smith'xn--80ak6aa92e.comis changed toаррӏе.comAlso need to add a best error messagedone.Checklist
Documentation reflects the changes where applicablechanges/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)