Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove iter, manually count positions #1

Merged
merged 9 commits into from May 30, 2022
Merged

Remove iter, manually count positions #1

merged 9 commits into from May 30, 2022

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented May 30, 2022 •
edited

Tried a custom iterator, but in the end it's even faster if we remove the iterator and count byte positions manually.

By f657cd3 there's a good custom iterator which is already significantly faster.

@samuelcolvin samuelcolvin changed the title Custom iter Remove iter, manually count positions May 30, 2022
@samuelcolvin samuelcolvin marked this pull request as ready for review May 30, 2022 20:24
@samuelcolvin samuelcolvin merged commit db0f26e into main May 30, 2022
@samuelcolvin samuelcolvin deleted the custom-iter branch May 30, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@samuelcolvin