Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comparison operators #8

Merged
merged 7 commits into from Jun 9, 2022
Merged

comparison operators #8

merged 7 commits into from Jun 9, 2022

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Jun 8, 2022

fix #6

To check:

  • not sure the timezone comparison is right if the date/time is different
  • maybe we need to support naive vs. non-naive comparison for pydantic?

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #8 (620e4f6) into main (1bbd69d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          546       597   +51     
=========================================
+ Hits           546       597   +51     
Impacted Files Coverage Δ
src/lib.rs 100.00% <ø> (ø)
src/date.rs 100.00% <100.00%> (ø)
src/datetime.rs 100.00% <100.00%> (ø)
src/duration.rs 100.00% <100.00%> (ø)
src/time.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbd69d...620e4f6. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 3a2ff6c into main Jun 9, 2022
@samuelcolvin samuelcolvin deleted the comparison branch June 9, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add gt, lt etc. comparison
1 participant