You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
also deletes the video in question if the quality is not the same as the desired quality set.
If a 360p video is set to be downloaded and a 720p video of it exists, the 720p video is deleted before the download even starts. This is potentially bad if the user downloads some large playlist frequently and forgets to change the quality in settings.
Deleting a video in a function named in a way that only a check is expected is bad design
The text was updated successfully, but these errors were encountered:
It looks like the function call to isVideoStored() in
https://github.com/samuelechu/YoutubePlaylist-Downloader/blob/master/Music%20Player/DownloadManager.swift#L60
also deletes the video in question if the quality is not the same as the desired quality set.
If a 360p video is set to be downloaded and a 720p video of it exists, the 720p video is deleted before the download even starts. This is potentially bad if the user downloads some large playlist frequently and forgets to change the quality in settings.
Deleting a video in a function named in a way that only a check is expected is bad design
The text was updated successfully, but these errors were encountered: