Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preemptive deletion of videos when different quality is set to Download #34

Open
samuelechu opened this issue Aug 18, 2018 · 0 comments

Comments

@samuelechu
Copy link
Owner

It looks like the function call to isVideoStored() in
https://github.com/samuelechu/YoutubePlaylist-Downloader/blob/master/Music%20Player/DownloadManager.swift#L60

also deletes the video in question if the quality is not the same as the desired quality set.
If a 360p video is set to be downloaded and a 720p video of it exists, the 720p video is deleted before the download even starts. This is potentially bad if the user downloads some large playlist frequently and forgets to change the quality in settings.

Deleting a video in a function named in a way that only a check is expected is bad design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant