Prevent Duplicate Key Error when 'key' is passed into constructor. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixed an error with a duplicate key when the LinkWell widget is constructed passing in the 'key' value. Error was: Multiple widgets used the same GlobalKey.
Upgrading version number in podspec so Linkwell can be used with the url_launcher that supports null safety. Note, this change will force apps to also update url_launcher & link_text to the null safety versions.
|
Also added a commit upgrading version number in podspec so Linkwell can be used with the url_launcher that supports null safety. Note, this change will force apps to also update url_launcher & link_text to the null safety versions. |
|
Great work man. Sorry I didn't see this until now. |
|
Cool, thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixed an error with a duplicate key when the LinkWell widget is constructed passing in the 'key' value.
Error was:
Multiple widgets used the same GlobalKey.
This error never occurred unless the caller passed in a Key. It is easy in the old version to create this problem by just passing in a key in the constructor. The new version works correctly when passing in a key.