Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin no longer works on OctoberCMS v3 due to changes to OctobeCMS Ajax API #126

Closed
andrepo opened this issue Jun 21, 2023 · 2 comments
Closed

Comments

@andrepo
Copy link

andrepo commented Jun 21, 2023

PR suggestion to make it work:

var component = $('*[data-file="' + name + '"]').data('component'); // check for component name

Change to
const componentSelector = '*[data-file="' + name + '"]';
const handler = $(componentSelector).data('component'); // check for component name
console.log('Processing [', name, '] - component [', componentSelector, '] - handler', handler);
oc.request(
componentSelector,
handler,
{
data: {
file: name,
content: regions[name]
}
}
);

@Zmove
Copy link

Zmove commented Aug 25, 2023

It would also be great to remove jquery dependency as it's not required anymore with ocms 3.x

@Samuell1
Copy link
Owner

Closed by #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants