Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

members.delete should return values consistent with Array and Hash #34

Closed
elrayle opened this issue May 18, 2015 · 2 comments
Closed

members.delete should return values consistent with Array and Hash #34

elrayle opened this issue May 18, 2015 · 2 comments

Comments

@elrayle
Copy link
Contributor

elrayle commented May 18, 2015

Array and Hash return nil if the item to delete is out of range or the specified key is missing. If the item to delete is correctly deleted, then the deleted item is returned.

Similarly, it is expected that members.delete and related_objects.delete will return...

  • return child_collection/object when successful delete
  • return nil if child_collection/object does not exist in parent_collection/object
  • raise error for any other problems

Related to samvera/hydra-pcdm#103.

@elrayle
Copy link
Contributor Author

elrayle commented May 18, 2015

See also #36, which describe similar issues for related_objects.

@elrayle
Copy link
Contributor Author

elrayle commented Jul 16, 2015

No longer appears to be an issue.

@elrayle elrayle closed this as completed Jul 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant