Updates the Fedora port used in executors #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Fedora docker image mounts the application at /, rather than /fcrepo/, so the port used by the executors with Fedora was wrong.
|
Failures before this change were all Ldp::HttpError: Status 405: https://app.circleci.com/pipelines/github/samvera/hyrax/3602/workflows/ecd1c1da-331d-41d0-8067-f4bbb10965b3/jobs/23471 Versus failures after are not: https://app.circleci.com/pipelines/github/samvera/hyrax/3718/workflows/e032bfbc-1c26-4add-83e4-1975bd88a336/jobs/24758 |
cjcolvar
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
👍 This looks good. I was concerned about backwards-compatibility but projects should have been generated with compatible configs for a good long while now and if there are any old projects which don't use FCREPO_TEST_PORT (or removed it) it should be pretty easy to fix in config/fedora.yml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fedora docker image mounts the application at /, rather than /fcrepo/, so the port used by the executors with Fedora was wrong.