Skip to content

Commit

Permalink
Remove ActiveFedora from the documentation and test setup
Browse files Browse the repository at this point in the history
Fixes #549

ActiveFedora is no longer required for the test suite and should not be
referenced in the documentation.

Note: There is a briefly delay during one of the tests when ActiveFedora
is first called, in order to test the deprecation warning.
  • Loading branch information
awead committed Aug 9, 2018
1 parent 9615464 commit efeb495
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -59,7 +59,7 @@ Rails.application.config.to_prepare do
)
Valkyrie::StorageAdapter.register(
Valkyrie::Storage::Fedora.new(connection: ActiveFedora.fedora.connection),
Valkyrie::Storage::Fedora.new(connection: Ldp::Client.new("http://localhost:8988/rest")),
:fedora
)
Expand Down
6 changes: 3 additions & 3 deletions lib/valkyrie/persistence/fedora/list_node.rb
Expand Up @@ -18,7 +18,7 @@ def initialize(node_cache, rdf_subject, adapter, graph = RDF::Repository.new)
end

# Returns the next proxy or a tail sentinel.
# @return [ActiveFedora::Orders::ListNode]
# @return [RDF::URI]
def next
@next ||=
if next_uri
Expand All @@ -31,13 +31,13 @@ def next
end

# Returns the previous proxy or a head sentinel.
# @return [ActiveFedora::Orders::ListNode]
# @return [RDF::URI]
def prev
@prev ||= node_cache.fetch(prev_uri) if prev_uri
end

# Graph representation of node.
# @return [ActiveFedora::Orders::ListNode::Resource]
# @return [Valkyrie::Persistence::Fedora::ListNode::Resource]
def to_graph
return RDF::Graph.new if target_id.blank?
g = Resource.new(rdf_subject)
Expand Down
4 changes: 0 additions & 4 deletions spec/spec_helper.rb
Expand Up @@ -21,9 +21,5 @@

SOLR_TEST_URL = "http://127.0.0.1:#{ENV['TEST_JETTY_PORT'] || 8984}/solr/blacklight-core-test"

# Setup to use the fedora.yml in the test app
ActiveFedora.init(environment: ENV['RACK_ENV'],
fedora_config_path: File.expand_path("../../config/fedora.yml", __FILE__))

ROOT_PATH = Pathname.new(Dir.pwd)
Dir[Pathname.new("./").join("spec", "support", "**", "*.rb")].sort.each { |file| require_relative file.gsub(/^spec\//, "") }

0 comments on commit efeb495

Please sign in to comment.