Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An instance of a metadata_adapter should report its ID #487

Closed
hackartisan opened this issue Jul 31, 2018 · 0 comments
Closed

An instance of a metadata_adapter should report its ID #487

hackartisan opened this issue Jul 31, 2018 · 0 comments
Assignees

Comments

@hackartisan
Copy link
Contributor

hackartisan commented Jul 31, 2018

optional parameters include

[adapter_type]:[host]:[port]:[path]

The combination of parameters should be unique to a given adapter, then hashed with md5 to make it more portable.

Use case example:
if we hash the IDs we can make a custom Valkyrie::Type which can cast a string like lock_token:a98sdfh98ashdf:my_id to a token, define the field as a Valkyrie::Types::Set.of(Valkyrie::Types::OptimisticLockToken), and then an application developer could just put it in the form and it'd work.
(note this use case requires more tickets)

required by #486
child of #286

@hackartisan hackartisan changed the title An instance of an adapter should report its ID An instance of a metadata_adapter should report its ID Aug 1, 2018
@hackartisan hackartisan self-assigned this Aug 1, 2018
hackartisan added a commit that referenced this issue Aug 1, 2018
refs #487

Co-authored-by: Adam Wead <amsterdamos@gmail.com>
Co-authored-by: Michael Tribone <mtribone@psu.edu>
hackartisan added a commit that referenced this issue Aug 1, 2018
refs #487

Co-authored-by: Adam Wead <amsterdamos@gmail.com>
Co-authored-by: Michael Tribone <mtribone@psu.edu>
hackartisan added a commit that referenced this issue Aug 1, 2018
resolves #487

Co-authored-by: Adam Wead <amsterdamos@gmail.com>
Co-authored-by: Michael Tribone <mtribone@psu.edu>
jrgriffiniii pushed a commit that referenced this issue Aug 7, 2018
resolves #487

Co-authored-by: Adam Wead <amsterdamos@gmail.com>
Co-authored-by: Michael Tribone <mtribone@psu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants