New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerize Valkyrie's dependencies #422
Conversation
Update the README with documentation on using Docker for dependencies
When I try to spin this up, I get:
|
valkyrie.gemspec
Outdated
@@ -47,6 +47,5 @@ Gem::Specification.new do |spec| | |||
spec.add_development_dependency "coveralls" | |||
spec.add_development_dependency "bixby" | |||
spec.add_development_dependency 'yard' | |||
spec.add_development_dependency 'solr_wrapper' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should keep both versions. I know some people at least have trouble getting Docker to work.
README.md
Outdated
* [Docker](https://store.docker.com/search?offering=community&type=edition) version >= 17.09.0 | ||
|
||
### Starting the development mode dependencies | ||
1. Start Solr, Fedora, and PostgreSQL with `rake docker:dev:daemon` (or `rake docker:dev:up` in a separate shell to run them in the foreground) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run rake docker:dev:up
, I get an error message:
Couldn't connect to Docker daemon - you might need to run `docker-machine start default`.
rake aborted!
Docker::Compose::Error: 'up' failed with status 'pid 21346 exit 1': Couldn't connect to Docker daemon - you might need to run `docker-machine start default`.
/Users/escowles/.rbenv/versions/2.3.1/bin/bundle:23:in `load'
/Users/escowles/.rbenv/versions/2.3.1/bin/bundle:23:in `<main>'
Tasks: TOP => docker:dev:up
(See full trace by running task with --trace)
Is there something I need to start before running the rake task?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I installed docker using homebrew: $ brew install docker
$ brew install docker-machine
$ brew install docker-compose And then I had to start it with: $ docker-machine create default
$ docker-machine start default
$ eval "$(docker-machine env)" For people who aren't familiar with Docker, it would be good to include that in the README. Edit by @revgum : Added docker-compose install and docker-machine creation |
@mbklein Are you going to be able to get back to this, or would you like me to take over documentation? |
Added two steps in @escowles comment and got it up and running on my box in a snap. Great work and addition IMO! Edit Almost all came up.. Solr was misbehaving for me, and after a bit of digging I figured out what was happening. I have a
|
This PR moves Valkyrie's external dependencies (Fedora, Solr, and PostgreSQL) into Docker containers.
Changes:
docker-compose.yml
files for development and test environmentsfcrepo_wrapper
andsolr_wrapper
and related rake taskscircle.yml
to make CircleCI use the new dependencies