Fedora 5 support #617
Merged
Fedora 5 support #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is hilarious. I think it should be an adapter configuration though, so people can talk to both, if it's this easy. |
escowles
force-pushed
the
fedora_5_escowles
branch
2 times, most recently
from
87d3ef4
to
2207765
Compare
escowles
commented
Nov 17, 2018
.circleci/config.yml
Outdated
| name: Run Specs (Fedora 5 compatibility) | ||
| command: bundle exec rake docker:spec | ||
| environment: | ||
| FCREPO_VERSION: 5.0.0-RC-1 |
There was a problem hiding this comment.
@mbklein Is there an easy way to configure the version of Fedora that the Docker container uses?
There was a problem hiding this comment.
Looking into it, but first I have to get a Fedora 5 container built.
escowles
force-pushed
the
fedora_5_escowles
branch
4 times, most recently
from
8fa81fc
to
e7dd8b9
Compare
This isn't how we'll want to really do it, because we're likely going to need two adapters, but this at least gets the ball rolling.
tpendragon
force-pushed
the
fedora_5_escowles
branch
from
91e857e
to
73d9106
Compare
escowles
force-pushed
the
fedora_5_escowles
branch
from
daab14c
to
bcf20f1
Compare
…havior for Fedora 5.0)
escowles
force-pushed
the
fedora_5_escowles
branch
from
bcf20f1
to
72d7be3
Compare
awead
suggested changes
Dec 5, 2018
| attribute :nested_resource | ||
| [4, 5].each do |fedora_version| | ||
| context "fedora #{fedora_version}" do | ||
| let(:fedora_version) { 4 } |
There was a problem hiding this comment.
Is this overriding fedora_version on line 6 above?
There was a problem hiding this comment.
I don't think so, but just in case I changed it.
awead
approved these changes
Dec 5, 2018
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Fedora 5 compatibility, via a new
fedora_versionparameter to the Fedora metadata and storage adapters.