Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Files... Add Folder... Buttons are missing hover selections via Keyboard #3451

Closed
chrisdaaz opened this issue Nov 29, 2018 · 3 comments · Fixed by #3883
Closed

Add Files... Add Folder... Buttons are missing hover selections via Keyboard #3451

chrisdaaz opened this issue Nov 29, 2018 · 3 comments · Fixed by #3883

Comments

@chrisdaaz
Copy link

Descriptive summary

Hyrax Master -- 3.0.0 beta

Rationale

This helps keyboard users add files and folders to works.

Expected behavior

Users who tab throughout the edit work page should be able to notice when they have selected the Add Files and Add Folder buttons, like the Add cloud files button:

image

Actual behavior

Tabbing through that section of the page, it appears to the user that the Add Files and Add Folder buttons are skipped. They are not actually skipped; keyboard users can still add files and folders, but they don't see the same UI behavior for those buttons as they do for the Add cloud files button.

Steps to reproduce the behavior

  1. Visit the Add New or Edit Work page
  2. Tab through the page to the Files section
  3. Try to select the Add files or Add folder buttons

Related work

Link to related tickets or prior related work here.

@vantuyls vantuyls added this to Backlog in Hyrax 3.0.0 Release Dec 7, 2018
@no-reply no-reply added this to the 3.x series milestone Jan 4, 2019
@mtribone
Copy link
Contributor

Just posting the 2.0.0 issue for reference. #1246

@kellyChex
Copy link

Confirmed this works on Nurax.

@kellyChex kellyChex moved this from QA to Done in Hyrax 3.0.0 Release Aug 5, 2019
@jessicahilt jessicahilt moved this from Done to QA in Hyrax 3.0.0 Release Sep 13, 2019
@dlim87
Copy link

dlim87 commented Sep 17, 2019

QA - this is still working in nurax

@kellyChex kellyChex moved this from QA to Done in Hyrax 3.0.0 Release Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment