Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jQuery version #5080

Open
jlhardes opened this issue Aug 18, 2021 · 3 comments
Open

Update jQuery version #5080

jlhardes opened this issue Aug 18, 2021 · 3 comments
Milestone

Comments

@jlhardes
Copy link
Contributor

Descriptive summary

An institution using Hyrax 2.x has recently received a security report from their institution's computer department, where they point to an old version of jQuery (1.12.4) as a possible security risk from within their Hyrax application. In trying to change to jQuery 3.x, many frontend features in Hyrax stopped working.

Rationale

Need to update dependencies to use a more current version of jQuery. If 1.12.4 is the version Hyrax is using, that is from 2016 and over 5 years old (https://github.com/jquery/jquery/tags?after=3.1.1). Current jQuery version is 3.6.0. Samvera Design Principles for Applications (working draft: https://samvera.atlassian.net/wiki/spaces/samvera/pages/922157098/Design+Principles+for+Samvera+Applications?focusedCommentId=1211105298) recommends a sustainability principle to keep technologies upon which an app is built to 2 years old or less.

Related work

Unclear how jQuery-dependent Hyrax is at this point. It looks like there is suggested work to move away from jQuery but these issues are still open:

#99 - replace jquery-ui autocomplete with typeahead.js
#365 - Support multiple file uploads per request
#3920 - Explore Webpack(er) for replacing jquery-datatables-rails

@rodyoukai
Copy link
Contributor

rodyoukai commented Aug 18, 2021

Update

I have succes to update to Jquery3, I but was forced to remove browse-everything JS code for this.

ColmexBDCV/colmex_hyrax@3ff11b2

@no-reply
Copy link
Contributor

@rodyoukai this is great! any chance you have bandwidth to create a branch and/or submit a PR here with some of these changes? if you could start moving this forward, i think the WG would be able to help carry it over the line

@no-reply no-reply added this to the 3.x series milestone Aug 18, 2021
@rodyoukai
Copy link
Contributor

rodyoukai commented Aug 25, 2021

hi @no-reply, sorry, I'm not sure if I understand you, I try to say it in my own words:

You ask me create a fork for the hyrax gem, create a branch and apply all change that I do in my own implementation of the hyrax system, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants