Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds workflow to trigger nurax deploy on push #5253

Merged
merged 1 commit into from Jan 19, 2022
Merged

Adds workflow to trigger nurax deploy on push #5253

merged 1 commit into from Jan 19, 2022

Conversation

mlooney
Copy link

@mlooney mlooney commented Nov 9, 2021

@samvera/hyrax-code-reviewers

@no-reply
Copy link
Member

note that this adds a new use of GitHub Actions.

is this something we're open to?

@dlpierce
Copy link
Contributor

What is the concern? If GH Actions were to become non-free for public repos in the future?

@no-reply
Copy link
Member

What is the concern? If GH Actions were to become non-free for public repos in the future?

i think it's mainly just that it's one more pipeline to configure and monitor, and one more configuration format to manage.

i don't have any other github actions projects, so personally i would probably avoid doing maintenance on this.

@elrayle
Copy link
Contributor

elrayle commented Dec 3, 2021

For context, the purpose of this is to provide an auto-deploy to the DCE supported nurax-dev and nurax-stable test applications. It connects into github actions in curationexperts/nurax. Without these, someone would have to manually deploy nurax-dev and nurax-stable.

I understand that this adds another pipeline, but it reduces manual monitoring. As such, I am in favor of merging this PR.

@elrayle
Copy link
Contributor

elrayle commented Dec 7, 2021

@no-reply Are you open to having this merged?

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had activity for 30 days. It will be closed if no further activity occurs within 14 days. Thank you for your contributions.

@stale stale bot added the stale label Jan 9, 2022
@elrayle elrayle removed the stale label Jan 12, 2022
@elrayle
Copy link
Contributor

elrayle commented Jan 19, 2022

Discussed today in Tech Call and there are no blockers to this being merged. There was a question about who would maintain this pipeline. There are several folks, including DCE staff, that work with Github Actions. So it seems like there are members of the community that can help maintain this pipeline.

It is also worth noting that this is not a critical pipeline. If it fails, it only impacts nurax related deploys. Additionally there are manual steps to deploy that would address the failure.

Copy link
Contributor

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. It will be nice to have the auto-deploys working.

@elrayle elrayle merged commit 03201a5 into main Jan 19, 2022
@elrayle elrayle deleted the repo_dispatch branch January 19, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants