Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searches with collections in results are failing #5463

Closed
jlhardes opened this issue Feb 23, 2022 · 5 comments · Fixed by #5515
Closed

Searches with collections in results are failing #5463

jlhardes opened this issue Feb 23, 2022 · 5 comments · Fixed by #5515
Assignees
Labels
Collection impacts the Collection part of PCDM Model Effort: Moderate valkyrization

Comments

@jlhardes
Copy link
Contributor

Descriptive summary

Conducting a search for a term that brings back any collection in the result set is failing with "ActionView::MissingTemplate in Catalog#index" error:
Screen Shot 2022-02-23 at 4 07 39 PM

Steps to reproduce the behavior

  1. Search nurax-pg for term that only appears in works (like "cat" - https://nurax-pg.curationexperts.com/catalog?utf8=%E2%9C%93&locale=en&search_field=all_fields&q=cat) - this search works correctly and brings back results
  2. Search nurax-pg for term that includes collections in the results (like "test" - https://nurax-pg.curationexperts.com/catalog?utf8=%E2%9C%93&locale=en&search_field=all_fields&q=test) - this search fails with error message
@jlhardes
Copy link
Contributor Author

This same error also occurs when trying to access paginated search results. Steps to reproduce the behavior:

  1. From https://nurax-pg.curationexperts.com/?locale=en, click the Go button on the search box (conduct a blank search to bring back all results, which should provide multiple pages of results)
  2. Click "Next >>" link at top of search results page or Next or numbered link at bottom of search results page

@elrayle elrayle added this to Ready in Hyrax-Valkyrization Mar 1, 2022
@elrayle
Copy link
Contributor

elrayle commented Mar 4, 2022

On Hyrax, it indexes the model as Collection even when the source is a Hyrax::PcdmCollection. On nurax-pg, the model is indexed as Hyrax::PcdmCollection. It may be difficult to reproduce this in Hyrax.

@elrayle
Copy link
Contributor

elrayle commented Mar 4, 2022

May want to have the search code accept both models in the search.

@tpendragon
Copy link
Contributor

Goal is to get Blacklight to render the collection partials for both Collection & Hyrax::PcdmCollection

@elrayle elrayle added Collection impacts the Collection part of PCDM Model Effort: Moderate labels Mar 4, 2022
@cjcolvar cjcolvar self-assigned this Mar 8, 2022
@elrayle elrayle moved this from Ready to In Progress in Hyrax-Valkyrization Mar 8, 2022
@elrayle elrayle moved this from In Progress to DONE in Hyrax-Valkyrization Mar 9, 2022
@rjkati
Copy link

rjkati commented Mar 21, 2022

Retested on Chrome/Windows and works as expected.

@jlhardes jlhardes moved this from DONE to Ready to be Archived in Hyrax-Valkyrization Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Collection impacts the Collection part of PCDM Model Effort: Moderate valkyrization
Projects
Hyrax-Valkyrization
Ready to be Archived
Development

Successfully merging a pull request may close this issue.

5 participants