Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if transaction fails when saving edit work changeset, value! was called on Failure exception was raised #5466

Closed
elrayle opened this issue Feb 24, 2022 · 1 comment

Comments

@elrayle
Copy link
Contributor

elrayle commented Feb 24, 2022

Descriptive summary

When saving the edit work form for a new Valkyrie resource work, if a transaction fails, exception value! was called on Failure raised.

Rationale

Edit form for works should handle form transaction failures gracefully.

Expected behavior

When a transaction error occurs after saving a work edit form, the edit form should reload and a flash message should show the cause of the failure.

Actual behavior

When a transaction error occurs after saving a work edit form, an exception is raised.

image

Steps to reproduce the behavior

Prerequisite

edit save transaction step and force it to always fail

To Reproduce

  1. navigate to: Dashboard -> Works
  2. click select menu under Actions and select: Edit
  3. change any metadata field value
  4. click button: Save

The exception shown in Actual behavior will be raised.

Related work

Similar failure happens for validations.

@elrayle
Copy link
Contributor Author

elrayle commented Mar 1, 2022

Fixed by PR #5448

@elrayle elrayle closed this as completed Mar 1, 2022
@elrayle elrayle added this to DONE in Hyrax-Valkyrization Mar 1, 2022
@elrayle elrayle moved this from DONE to Ready to be Archived in Hyrax-Valkyrization Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Hyrax-Valkyrization
Ready to be Archived
Development

No branches or pull requests

1 participant