Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch delete works fails with unknown keyword :use_valkyrie with non-wings adapters #5512

Closed
elrayle opened this issue Mar 9, 2022 · 0 comments · Fixed by #5513
Closed

Comments

@elrayle
Copy link
Contributor

elrayle commented Mar 9, 2022

Descriptive summary

Adapter: postgres

Deleting multiple works passes parameter use_valkyrie to find_by_alternate_identifier, but query_services for non-wings adapters do not define that parameter. This causes an exception to be raised.

Expected behavior

Deleting a batch of works should complete without error.

Actual behavior

Deleting a batch of works raises an exception.

image

Steps to reproduce the behavior

Prerequisites

  • create several Valkyrie::Resource works (e.g. Monograph)

To Reproduce

  1. Navigate to: Dashboard -> Works
  2. Check the box beside at least 2 works created in prerequisites
  3. Click button: Delete Selected
  4. Click button: OK

Will fail with exception seen in Actual behavior section.

@elrayle elrayle added this to In Progress in Hyrax-Valkyrization Mar 9, 2022
@elrayle elrayle self-assigned this Mar 9, 2022
@elrayle elrayle moved this from In Progress to Ready for Review in Hyrax-Valkyrization Mar 9, 2022
@elrayle elrayle moved this from Ready for Review to DONE in Hyrax-Valkyrization Mar 9, 2022
@jlhardes jlhardes moved this from DONE to Ready to be Archived in Hyrax-Valkyrization Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Hyrax-Valkyrization
Ready to be Archived
Development

Successfully merging a pull request may close this issue.

1 participant