Review and Approval error on one-step mediated workflow

[jlhardes]

Descriptive summary

Approving a one-step mediated deposit Work results in an error message "Ldp::Gone in Hyrax::WorkflowActionsController#update". Returning to Work view page still shows Review and Approval menu even though approval action was taken and Work is labeled Deposited.

Expected behavior

Approval should not result in error message and viewing work after approval should not continue providing Review and Approval menu.

Actual behavior

Experiencing error "Ldp::Gone in Hyrax::WorkflowActionsController#update" when approving a Work:

Review and Approval menu still shows even when Work is approved and labeled Deposited:

Steps to reproduce the behavior

1. Log in as an admin user, create a one-step deposit admin set (create new collection of type "Admin Set", under Workflow tab select "One-step mediated deposit workflow")
2. Log in as non-admin user and submit new work to the one-step workflow admin set - set to public
3. Log in as an admin user and go to Dashboard: Tasks: Review Submissions
4. Click on work title, see "Review and Approval"
5. Select "Approve" and click Submit
6. Receive "Ldp::Gone in Hyrax::WorkflowActionsController#update" error message
7. Navigate back to Work show page as admin user
8. See Review and Approval menu still in place even with Work labeled as Deposited (and not Pending Review)

Related work

#5634 was fixed and then this issue was discovered.

[bwatson78]

@jlhardes Do you recall if this happened on a Generic Work? I just stepped through the behavior list on a Generic Work without error.

[jlhardes]

@bwatson78 it was a Generic Work, that is the only work type I have been testing on this branch.

[jlhardes]

Testing with bl7bootstrap4 branch locally again and this error is no longer occurring. Established that returning to Work view page and still seeing Review and Approval menu as the reviewer/approver is working as it should (Approve is no longer an option as an action but Request Changes and Comment Only are still available; Work is labeled as Deposited).