Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Valkyrie/Fedora, filesets cannot be saved with a different visibility than works #6349

Closed
rjkati opened this issue Oct 9, 2023 · 4 comments

Comments

@rjkati
Copy link

rjkati commented Oct 9, 2023

Descriptive summary

When editing a fileset, you cannot change the visibility setting to a different visibility than the work

Steps to reproduce the behavior in User Interface (UI)

  1. Running locally with Valkyrie/Fedora, log in to dashboard as admin user or regular user
  2. Create a new Generic Work
  3. Add required metadata and a file
  4. Select Public as Visibility and save
  5. On the work show page, scroll to the Items list and click the fileset title
  6. Click Edit this File Set
  7. Click the Permissions tab
  8. Select Institution visibility
  9. Observe error message "There was a problem processing your request"

Actual behavior (include screenshots if available)

When attempting to save a fileset with a different visibility than the work, I get an error message "There was a problem processing your request"

Acceptance Criteria/Expected Behavior

Filesets should be able to have different visibility settings than the work.

Related work

#6337

@rjkati rjkati added this to Ready in Hyrax-Valkyrization Oct 9, 2023
@abelemlih abelemlih self-assigned this Oct 9, 2023
@abelemlih abelemlih moved this from Ready to In Progress in Hyrax-Valkyrization Oct 9, 2023
@bwatson78 bwatson78 assigned bwatson78 and unassigned abelemlih and bwatson78 Oct 9, 2023
@abelemlih abelemlih self-assigned this Oct 10, 2023
@abelemlih
Copy link
Contributor

@rjkati the reproduction steps of this ticket are inconsistent. I followed the steps outlined above, and got the same error mentioned during my first attempt at changing the fileset's visibility. When I attempted the change a second time, it processed successfully.

For reference, after the first successful change, I am now able to create new works and change their filesets' visibility without any issues.

@rjkati
Copy link
Author

rjkati commented Oct 11, 2023

I rebuilt my local build with the latest version of main and I'm now able to change the fileset visibility independently of the work without an error. @jlhardes could you please test and report back? If you also can't reproduce this, then I think we can close this ticket.

@rjkati rjkati moved this from In Progress to QA in Hyrax-Valkyrization Oct 11, 2023
@jlhardes
Copy link
Contributor

@rjkati I rebuilt as well and cannot reproduce the error from the instructions on this issue. I can update the fileset visibility independently from work visibility between Public and Private, at least.

@rjkati
Copy link
Author

rjkati commented Oct 11, 2023

Thanks @jlhardes. I am going to close this ticket as resolved and we can re-open it or create a new ticket if the issue occurs again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants