Sirenia testing - VR_1.2 test: error when approving or requesting changes on a 1 step workflow deposit

[eporter23]

Descriptive summary

When an Admin approves a deposit submitted through a basic 1-step workflow, it returns an Valkyrie::Persistence::ObjectNotFoundError in Hyrax::WorkflowActionsController#update error. Same error occurs if trying to request revisions on the work or if trying to Edit the work as an admin. The Dashboard notifications do show that the approval and review changes have occurred.

Steps to reproduce the behavior in User Interface (UI)

1. Create an Admin Set allowing 1-step workflow, and all visibility and release options (see test VR_1.2)
2. As a different user, create a new work and make sure it's assigned to this Admin Set
3. As an approving/admin user, go to review the new work
4. Fill out the approval options on the work and submit
5. See the below error message

Actual behavior (include screenshots if available)

Include what version of Hyrax relates to this issue (3.x, 4.x, main branch, etc.) if appropriate, and any relevant error messages/tracebacks if you're reporting a bug.

Hyrax 5rc2 main, Sirenia (Fedora 6) docker image

Note: the approval and/or request revisions activity does show up in the users' notifications:

Acceptance Criteria/Expected Behavior

• When a user with appropriate permissions is shown the option to Approve a 1-step deposit submission, they should not see an error message, and should be returned to the work with the appropriate status indicated
• The work should be transitioned to the Published/Deposited state

Rationale (for feature request only)

Provide the rationale or user story that describes "why" this issue should be addressed. Especially if this is a new feature or significant change to the existing implementation.

1-step workflows should be supported in Fedora 6-backed repositories

Related work

Link to related issues or prior related work here.

[eporter23]

In recent local testing at Emory, we are no longer seeing this issue (Hyrax 5.0.1, Fedora 6.5) so this may be closable after retesting by others.

[jlhardes]

I tried this out on Hyrax 5.0.1 locally with Sirenia and I cannot come up with an error. I set up the mediated deposit admin set and then as a non-admin user, I created a private work in that admin set. I approved it as the admin user and it worked. Then I created a public work as the non-admin user in that admin set and proceeded to have a review conversation between the admin user and the non-admin user about changes that were needed. The non-admin user made the changes and the admin user approved the deposit and it all worked. I could get to the work through the notifications links without any problems. I think this issue is resolved.