Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not possible to test using attributes #5

Open
rstoneIDBS opened this issue Apr 21, 2023 · 3 comments
Open

Not possible to test using attributes #5

rstoneIDBS opened this issue Apr 21, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@rstoneIDBS
Copy link

I'm just trying out your library and have found that its not possible to set attributes on components, some of our components don't map properties to attributes so can't be tested.
I've created a very small patch to fix this if you are interested in pulling it in.
@sand4rt
Copy link
Owner

sand4rt commented Apr 21, 2023

@rstoneIDBS Awesome, would be great!

@rstoneIDBS
Copy link
Author

rstoneIDBS commented Apr 21, 2023 •
edited
Loading

@rstoneIDBS Awesome, would be great!

I'm not entirely sure how to get this to you - do I need to fork this repo? Edit: I tried to create a branch but wasn't allowed.

@sand4rt
Copy link
Owner

sand4rt commented Apr 21, 2023 •
edited
Loading

Yeah, you will need to:

  1. Fork the repo
  2. Clone the forked repo
  3. Create a branch
  4. Commit the changes (using conventional commit) eg. fix: render attributes
  5. Go to the PR section in GitHub and you are able to create the PR there

@sand4rt sand4rt mentioned this issue Apr 24, 2023
Closed
@Anmo Anmo mentioned this issue May 15, 2023
Closed
@sand4rt sand4rt added the enhancement New feature or request label Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@sand4rt @rstoneIDBS