Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The default sandbox name "New Box" in the new create sandbox guide is translated. #2792

Closed
okrc opened this issue Apr 7, 2023 · 4 comments
Closed

The default sandbox name "New Box" in the new create sandbox guide is translated. #2792

okrc opened this issue Apr 7, 2023 · 4 comments
Labels
fixed in next build Fixed in the next Sandboxie version Issue reproduced Issue reproduced without uncertainties User interface Related to Plus and/or Classic UIs

Comments

@okrc
Copy link
Contributor

okrc commented Apr 7, 2023 •
edited

Describe what you noticed and did

Sandboxie/SandboxiePlus/SandMan/Wizards/NewBoxWizard.cpp

Lines 184 to 188 in 82d394b

QString NewName = tr("New Box");
if (i > 0) NewName.append(" " + QString::number(i));
if (Boxes.contains(NewName.toLower().replace(" ", "_")))
continue;
m_pBoxName->setText(NewName);

Whether this is expected behavior.

What version of Sandboxie are you running?

Sandboxie Plus 1.8.3 64bit
@okrc okrc added the Confirmation pending Further confirmation is requested label Apr 7, 2023
@DavidXanatos
Copy link
Member

whats wrong in having
"Neue Sandbox"
"Nowa piaskownice"
etc...
in other languages?

@okrc
Copy link
Contributor Author

okrc commented Apr 7, 2023

m.mp4

@DavidXanatos
Copy link
Member

oh right non asci languages... i see the problem

@DavidXanatos DavidXanatos added ToDo To be done Issue reproduced Issue reproduced without uncertainties and removed Confirmation pending Further confirmation is requested labels Apr 7, 2023
@bastik-1001
Copy link
Contributor

What's the ideal solution? Have the default string be static English, saying "New Box"?

This seems to be better than to let non ASCII translations differ, which would be another solution.

Support path names and thereby boxnames that can include non ASCII characters?

@DavidXanatos DavidXanatos added the fixed in next build Fixed in the next Sandboxie version label Apr 7, 2023
@isaak654 isaak654 added User interface Related to Plus and/or Classic UIs and removed ToDo To be done labels Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed in next build Fixed in the next Sandboxie version Issue reproduced Issue reproduced without uncertainties User interface Related to Plus and/or Classic UIs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bastik-1001 @DavidXanatos @isaak654 @okrc