Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start analysis again if a game contains analysis data already #312

Closed
Zaoliang opened this issue Jan 5, 2021 · 14 comments
Closed

Comments

@Zaoliang
Copy link

Zaoliang commented Jan 5, 2021

At moment Katrain starts analysis after a game has been loaded.
This keeps user waiting a while, depending on games progress or moves.

I would like see the analysis data can be used directly and analysis just start from last move or new move.

If it is needed for a re-analysis of a game for some reason, then please don't make this as default.

@ghost
Copy link

ghost commented Jan 6, 2021

I agree. Currently there is no way to access saved analysis data when loading a previously analysed game. All that is shown is the data from the re-analysis.

@sanderland
Copy link
Owner

If you have the 'save analysis in sgf' box tixed in 1.7 it should save it.
Other than that, having 'fast visits' low, even at 1, makes fast loading near instant.

@Zaoliang
Copy link
Author

Zaoliang commented Jan 6, 2021

@sanderland 'save analysis in sgf' ? I use vsion 1.7 already. I checked menu and analysis but I cannot find this option.
Thanks!

@sanderland
Copy link
Owner

image

@Zaoliang
Copy link
Author

Zaoliang commented Jan 6, 2021

@sanderland I tired this Cache analysis in SGF. No changes than before. Low the value to 1 for 'Show stats if mocre than..visits' doesn't help in my case.

@sanderland
Copy link
Owner

sanderland commented Jan 6, 2021

What did you try? Save a game with analysis and then load it?

Show stats if more than..visits' just changes which dots are solid with text vs small and faded

General/Engine settings has the visits thresholds

@Zaoliang
Copy link
Author

Zaoliang commented Jan 6, 2021

@sanderland Yes, I saved changes with anaylsis and then reload my game.
I tried now with low visits value in General/Engine settings, but this has no effect on behavior of analysis.
I mean it just starts analysis from beginning.

katrain visits setting

@sanderland
Copy link
Owner

sanderland commented Jan 6, 2021

@Zaoliang what exactly are you doing?

  • new game, play
  • save
  • load the resulting sgf

should load analysis

  • load downloaded sgf
  • analyze
  • save
  • load

has a bug which is fixed in 1.7.1

max visits should affect how much analysis is done. (fast visits if drag+drop or ticking 'fast' in load should be very quick with 10 visits!)

@Zaoliang
Copy link
Author

Zaoliang commented Jan 6, 2021

@sanderland load downloaded sgf, I see the difference. Thanks for your explanation!

yes, fast load option is useful, thanks again.

@ghost
Copy link

ghost commented Jan 6, 2021

I'm having this issue, even with "Cache analysis in SGF".

What I'm doing is:

  1. Load SGF file
  2. Wait for analysis
  3. Save SGF with analysis
  4. Close Katrain
  5. Reopen Katrain
  6. Load SGF with analysis

What I get is a new analysis, and all the analysis I've made before is not accessible.

@Zaoliang
Copy link
Author

Zaoliang commented Jan 6, 2021

@Azirine So I can reduce waiting time with load option 'Use fast analysis' :)

@ghost
Copy link

ghost commented Jan 6, 2021

@Azirine So I can reduce waiting time with load option 'Use fast analysis' :)

The problem is not the waiting time. When I set fast analysis with 1 visit, all that is shown is the analysis with 1 visit, even though I've done thousands of visits on every move before and saved it.

@sanderland
Copy link
Owner

@Azirine yes that's a bug that will is fixed in the next version. You can kind of work around it with 'save as', I think. Otherwise it forgets to save the analysis format version, and on loading it's like "wrong version, ignore!"

@sanderland
Copy link
Owner

fix released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants