Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on Drupal page #42

Closed
GoogleCodeExporter opened this issue Apr 21, 2015 · 8 comments
Closed

Not working on Drupal page #42

GoogleCodeExporter opened this issue Apr 21, 2015 · 8 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1.See page at "http://test.firstpointresources.com/div/information-technology"
2.See script file expand-box.js
3.Professional Staff div box, when highlighted should expand, and "plus" image 
beside "Professional Staff" should rotate 180 deg.
4.If I take out the lines 5 and 17, everything works (except for the image 
rotate of course.  

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.


Original issue reported on code.google.com by mathewjo...@gmail.com on 12 Aug 2011 at 2:42

@GoogleCodeExporter
Copy link
Author

Because a "image" is a HTML element not a jQuery element.... if you write 
something like $(image).rotate  then it will work...

Hope it helps ;)

Original comment by wil...@gmail.com on 12 Aug 2011 at 7:22

@GoogleCodeExporter
Copy link
Author

Not a plugin issue so closing.

Original comment by wil...@gmail.com on 12 Aug 2011 at 7:22

  • Changed state: Invalid

@GoogleCodeExporter
Copy link
Author

Thanks so much for the quick response. The "image" object in the functions
show() and hide() are both returned from the jquery first() function in the
createBox() function, so it is already a jquery element. But to be
double-dog sure I went ahead and tried it. It still didn't work. I left the
changes on the site, so that you could verify that I made the changes
correctly. I would like to point out though that, I have this same code on
an otherwise blank test-page and it works fine as-is (that is before
changing image to $(image)). Thanks again. Let me know what I should try
next.

Original comment by mathewjo...@gmail.com on 12 Aug 2011 at 8:52

@GoogleCodeExporter
Copy link
Author

Well so your problem is quite unusual. You have like 3 jQuery librares 
included. I assume that my plugin get loaded in middle of two of them so it 
attaches to the jQuery version that later on is overriden by a newer version 
(or just different one) - this way a .rotate function is not avail.

Try to use only one jQuery at all, or make sure that jQueryRotate plugin is 
loaded after the last jQuery library

Original comment by wil...@gmail.com on 15 Aug 2011 at 11:08

@GoogleCodeExporter
Copy link
Author

That was the problem. Thank you very much! Do you know why it would still
not work right in IE. It rotates once, and then it looks like it changes
positions upward slightly, and after that it doesn�t run again until the
page is refreshed. It looks great in Chrome, Firefox, Safari, and Opera (You
can see the correct behavior there), but in IE8 I get the above described
issue. BTW, awesome plug-in, it�s really slick looking. Thanks again for the
quick responses.

Original comment by mathewjo...@gmail.com on 15 Aug 2011 at 9:01

@GoogleCodeExporter
Copy link
Author

The problem why it doesnt work is this line:

    show($(elem).children('div'), $(elem).children('img').first());

and

    hide($(elem).children('div'), $(elem).children('img').first());


The problem is that this plugin to make rotation working in IE replaces IMG 
component with a VML-Image component. That means that selectors based on "img" 
will no longer works (as in your case).

To solve it you can for example change:

$(elem).children('img').first()

To something like this:

$(elem).children(':first').first()

This way you will always point to proper object.

Cheers,

Original comment by wil...@gmail.com on 16 Aug 2011 at 9:15

@GoogleCodeExporter
Copy link
Author

Issue 43 has been merged into this issue.

Original comment by wil...@gmail.com on 16 Aug 2011 at 9:15

@GoogleCodeExporter
Copy link
Author

Brilliant! Thanks, so much, man. This effect really gives a quality feel to the 
box. I appreciate your help with these issues.

Original comment by e...@martinclan.info on 16 Aug 2011 at 1:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant