Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not gracefully handle missing yarn binary #1

Open
sandfox opened this issue Feb 16, 2018 · 0 comments
Open

Does not gracefully handle missing yarn binary #1

sandfox opened this issue Feb 16, 2018 · 0 comments
Labels

Comments

@sandfox
Copy link
Owner

sandfox commented Feb 16, 2018

currently the script assumes that a yarn binary is present at the user supplied path.
If it's missing, or just something else the script fails in various ways

e.g

TypeError: Cannot read property 'trim' of null
    at getLocalYarnVersion (/Users/sandfox/code/ConnectedHomes/project/node_modules/@sandfox/bundled-yarn-updater/index.js:21:71)
    at fetch.then.then.payload (/Users/sandfox/code/ConnectedHomes/project/node_modules/@sandfox/bundled-yarn-updater/index.js:29:28)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

We should handle the missing file case with a nice error message, and maybe offer a cli. flag to "force install" (for example when starting a new project).

We should also handle when the binary is either not an executable thing, or something else with a nice error message.

@sandfox sandfox added the bug label Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant