-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release on pypi is broken #55
Comments
Longer term fix would be to remove any calls to plotly functions that start with _ |
Thanks for noting this issue - our automated tests picked this up earlier today and the pyGSTi beta branch has already been fixed to work with plotly v3.8. As you suggested, we could hotfix the master branch by simply pinning the plotly version to 3.7, which I expect we'll do soon. Let's leave this issue open until that happens. As an aside, one good thing coming from all this is that the functionality that pyGSTi needs from plotly is now (as of v3.8) exposed through the public api (no underscore functions) -- previously we unfortunately needed to utilize the |
Just for completeness, this issue is temporarily fixed by pinning the plotly version in the Version 0.9.7.3 release, which is available through PyPI/pip now as well. This pinning will be removed in future releases which will contain a more permanent fix. I believe this solves the issue raised by schuylerfried an so I'll close the this issue. |
Thank you! |
Error when trying to import module functions:
Turns out plotly released v3.8.0 like 11 hours ago, which removed this function
_plot_html_
. Easy fix is to pin the plotly version in your requirements.txt and setup.py, then tag and release a new version.The text was updated successfully, but these errors were encountered: