Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colon in filename of example notebooks creates problem on Windows #38

Closed
AdriaanRol opened this issue Jun 26, 2018 · 2 comments
Closed

Comments

@AdriaanRol
Copy link

@enielse

Hi Erik,
I recently tried updating to the latest version of the beta branch of pyGSTi. Whenever I try to check out the latest version I run into the problem that some example notebooks are not present (see screenshot below). This is flagged as file deletions by git.

It appears that the problem is because windows does not allow colons (:) in filenames. A simple solution would be to rename the offending notebooks.

image

@enielse
Copy link
Collaborator

enielse commented Jul 3, 2018

Thanks for pointing this out. We actually discovered this independently a just few weeks ago. The colons have been removed from all filenames on the develop branches now, and so they'll be fixed on the master branch at the next release (which will be 0.9.5), which we're aiming for a 1-2 weeks from now. Let's leave this issue open until that happens.

@enielse
Copy link
Collaborator

enielse commented Aug 30, 2018

Well... 1-2 weeks turned into 1-2 months, but version 0.9.5 is just out, and has the colon-free filenames .

@enielse enielse closed this as completed Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants