Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed server can fail due to a race condition. #466

Closed
tshead2 opened this issue Jul 1, 2015 · 1 comment
Closed

Feed server can fail due to a race condition. #466

tshead2 opened this issue Jul 1, 2015 · 1 comment
Assignees

Comments

@tshead2
Copy link
Member

tshead2 commented Jul 1, 2015

// feed server stderr log
[root@slycat-srn slycat]# ls -l feed-server-stderr.txt 
-rw-r--r-- 1 slycat slycat 1806 Jun  9 13:52 feed-server-stderr.txt
[root@slycat-srn slycat]# cat feed-server-stderr.txt 
ERROR:tornado.application:Uncaught exception in /changes-feed
Traceback (most recent call last):
  File "/home/slycat/install/conda/lib/python2.7/site-packages/tornado-4.1-py2.7-linux-x86_64.egg/tornado/websocket.py", line 402, in _run_callback
    callback(*args, **kwargs)
  File "/home/slycat/src/slycat/feed-server/slycat-feed-server.py", line 222, in open
    raw_feed.add_client(self)
  File "/home/slycat/src/slycat/feed-server/slycat-feed-server.py", line 177, in add_client
    if is_project_reader(self._projects[model["project"]], client.user):
KeyError: u'71f47b44e3abe0fd8f4e2d7796e3b355'
ERROR:tornado.application:Uncaught exception in /changes-feed
Traceback (most recent call last):
  File "/home/slycat/install/conda/lib/python2.7/site-packages/tornado-4.1-py2.7-linux-x86_64.egg/tornado/websocket.py", line 402, in _run_callback
    callback(*args, **kwargs)
  File "/home/slycat/src/slycat/feed-server/slycat-feed-server.py", line 222, in open
    raw_feed.add_client(self)
  File "/home/slycat/src/slycat/feed-server/slycat-feed-server.py", line 177, in add_client
    if is_project_reader(self._projects[model["project"]], client.user):
KeyError: u'71f47b44e3abe0fd8f4e2d7796e3b355'
ERROR:tornado.application:Uncaught exception in /changes-feed
Traceback (most recent call last):
  File "/home/slycat/install/conda/lib/python2.7/site-packages/tornado-4.1-py2.7-linux-x86_64.egg/tornado/websocket.py", line 402, in _run_callback
    callback(*args, **kwargs)
  File "/home/slycat/src/slycat/feed-server/slycat-feed-server.py", line 222, in open
    raw_feed.add_client(self)
  File "/home/slycat/src/slycat/feed-server/slycat-feed-server.py", line 177, in add_client
    if is_project_reader(self._projects[model["project"]], client.user):
KeyError: u'71f47b44e3abe0fd8f4e2d7796e3b355'
@tshead2
Copy link
Member Author

tshead2 commented Aug 3, 2015

It still isn't clear to me how this happens. However, I've added some code to catch the exception, log some useful information, and keep the server going.

@tshead2 tshead2 closed this as completed Aug 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant