Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin icon missing on hover image #482

Closed
pjcross opened this issue Aug 17, 2015 · 2 comments
Closed

Pin icon missing on hover image #482

pjcross opened this issue Aug 17, 2015 · 2 comments
Assignees

Comments

@pjcross
Copy link
Contributor

pjcross commented Aug 17, 2015

There are two different behaviors dependent on which browser you are using. In Firefox, there is no sign of the pin icon at all. Clicking in the corner does nothing. In Chrome, there is a broken image icon and clicking on it pins the image. I realize that our pinning behavior has evolved since the PIP model was written, but in addition to these bugs, I think the pinning behavior needs to be the same as the PS model. Currently, once you start moving the image, the broken image icon disappears and pinning is no longer possible. Whereas in PS, pinning is now always an option.

Here is the broken image icon:
image

@pjcross
Copy link
Contributor Author

pjcross commented Aug 17, 2015

I see the same behaviors in Firefox and Chrome on OS X as on Windows.

@pjcross pjcross changed the title Pin icon missing on hover image (windows 7) Pin icon missing on hover image Aug 17, 2015
@pjcross
Copy link
Contributor Author

pjcross commented Aug 18, 2015

On Safari, you see the ? icon instead of the pin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants