-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Allow specifying server in "add client" command #24
Comments
The way Wiretap is currently structured, this might be a little tricky. Routing rules assume that the network is a tree, with clients being at the root of the tree. It might be doable if we assume that there is only one "first-hop" server, but if your initial client has multiple first-hop servers then it may not be possible to grant the new client access to both branches when added to an arbitrary server. Case that would probably work:
Case that will only allow the new client access to the right branch:
Thoughts? If you don't care about the second case, I could see about adding an option like you describe. It may also limit the new client's ability to add additional clients |
I think the only-one-first-hop case is what i'm thinking of. If i was working with parallel server chains i would probably just use two instances of wiretap vs having them combined. |
I have a draft of this working in the add-client-to-any-server branch. Would you mind trying it out to make sure it works as you intend? |
Yea it works how i expected. It seems like maybe the |
Thanks for testing, good catch. |
It would be useful to allow specifying the
--server-address ::6
in theadd client
command just like in theadd server
command. This would create a new client config that connects its relay to the server specified and e2e same as the original clientThe text was updated successfully, but these errors were encountered: