Update ALL the things! #15
Conversation
doubleo2
force-pushed
the
master
branch
2 times, most recently
from
d9b3669
to
bbee938
Compare
Replaced Tobi because it was unpublished from NPM and updated all other dependencies to build using the LTS version of Node (14.18.0) at time of writing
|
This looks great, I need to test this when I have a bit of time, also I think I can use it all for https://github.com/sandoche/Jekyll-webpack-boilerplate |
|
@doubleo2 the pwa doesn't work. I get: |
| '_site/**/**.html', | ||
| '_site/assets/images/**.*', | ||
| '_site/assets/**.js', | ||
| swDest: '_site/service-worker.js', |
There was a problem hiding this comment.
@sandoche Could it be this line? Unfortunately because I had never built this project before the tobi package was removed from npm, I didn't have a reference build to compare the updated output with. I also couldn't find a definitive answer online about the default destination of the original sw-precache tool
There was a problem hiding this comment.
I think the problem came from the fact that two webpack plugins were competing to create the manifest.json
My last push should have fixed it. Just waiting for the netlify build to test.
|
Great. I probably should have made it clear on my PR that I had no frame of
reference when I was testing my changes.
…On Thu, 7 Oct 2021 at 9:17 PM, Sandoche ADITTANE ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In config/sw.config.js
<#15 (comment)>
:
> @@ -1,15 +1,18 @@
module.exports = {
- staticFileGlobs: [
- '_site/assets/**.css',
- '_site/**.html',
- '_site/**/**.html',
- '_site/assets/images/**.*',
- '_site/assets/**.js',
+ swDest: '_site/service-worker.js',
I think the problem came from the fact that two webpack plugins were
competing to create the manifest.json
My last push should have fixed it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABLUY5IHP7CTU5XXQCPUI3UFWMVZANCNFSM5FBKU56A>
.
|
|
It's pretty strange it works locally but not on production. |
|
I know why , my bad. The default build command of netlify use the build without pwa. I will leave this out since it's a website to showcase your app. It should not require the PWA. |
|
I know why , my bad. |
Replaced Tobi because it was unpublished from NPM and updated all other dependencies to build using the LTS version of Node (14.18.0) at time of writing