-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JSON response when tagging #29
Comments
That`s a good point. I'll see what I can do here. |
@advplyr
My current implementation plan is:
The patch plan is not ready yet and maybe change to full result because I have to check a library that offers the JsonDiff stuff... I would also use the "NON RFC" Patch variant, although I love RFCs it is not helpful to see what operations must be applied in the terminal but only the "changeset"... |
Having some indication that the process executed is helpful. I'm not sure what that would be though, so as long as the exit code is 0 and nothing is returned then I can work with that.
I think it is perfectly fine to return the full metadata information. For Abs when applying the updates to objects we will be comparing the new details with the old ones anyway. However, returning just the patched information is probably more friendly to other clients. If it saves you from including another package in the library then I would say just return the full metadata.
No output on stdout and error message in stderr. Ideally the error message is something I could show the user. If you have more complete error data then that would require a JSON object.
This plan works for me. Abs doesn't need the patch information necessarily so the full metadata is also fine. Thanks for working on this! |
When tagging there is only a response to be used in a CLI.
Also, when the tag fails there is no way to check if the tag failed since everything is written to stdout.
The text was updated successfully, but these errors were encountered: