Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random performance improvements #279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yawkat
Copy link

@yawkat yawkat commented Oct 24, 2016

I have a very large quassel core with many buffers and many users in those buffers, and quasseldroid is very slow to connect (4 minutes) for me. These changes attempt to fix some of the most obvious issues, cutting down connect time by 50% or 2 minutes for me.

Some of these solutions are more patching up than real fixes (especially that Executor...) but it works.

Feel free to cherry-pick individual changes from this PR, or split it into multiple commits, I don't really care since it runs fine on my phone now :)

@justjanne
Copy link
Collaborator

This is actually very close to what I’ve done for the rewrite, but awesome!

I’ll merge this right now.

@jgkamat
Copy link

jgkamat commented Mar 1, 2017

@justjanne I haven't tested this out, so I'm not sure if it works, but a faster connection time would be very nice to have, so if this works, can it be mered into master?

@yawkat
Copy link
Author

yawkat commented Mar 1, 2017

These changes do work, but they are far from an ideal solution. They were hacked together in half an hour and this PR is only meant as a hint on important bottlenecks in the connection phase.

@justjanne
Copy link
Collaborator

@yawkat: There’s still an issue with the ObjectName – nextUniqueInteger won’t work, because the ObjectName is defined on the server.

If you change that part, the rest seems to work nicely, so I’d be willing to merge that.

@justjanne
Copy link
Collaborator

@yawkat Also, could you update the BuildTools and android-sdk versions? Then Travis CI should be able to build it, too (and the checks would work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants