You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a similar library to this, Remix Routes, that supports adding query parameters to URLs with the path helper. Could this functionality be added to this package?
$path("/home", { foo: "bar" }) - appends foo as a query string (a runtime check was done here) $path("/product/:id", { id: "1" }, { foo: "bar" }) - appends foo as a query string (a runtime check was done here)
I'm not really sure if we can achieve the same usage interface, since we're just exporting type annotations and we're not doing any runtime checks.
So basically there are 2 questions:
Do we need this at all if we can achieve this with string literals? Those parameters are not strongly typed anyway, so what's the benefit of passing them via an object instead of a string concatination?
If we want this, what would be the interface for setting query strings (taking into consideration that we're just exporting type annotations and we can't know if the second parameter of the route function is actually an object of parameters or query parameters)?
Describe the bug
Discussions are not enabled so I am using this.
There is a similar library to this, Remix Routes, that supports adding query parameters to URLs with the path helper. Could this functionality be added to this package?
Your Example Website or App
https://github.com/yesmeck/remix-routes
Steps to Reproduce the Bug or Issue
N/A
Expected behavior
Query parameters can be added to the path with the helper.
Screenshots or Videos
No response
Platform
Additional context
No response
The text was updated successfully, but these errors were encountered: