change devDependencies to dependencies #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had chalk v5 installed in my project, which raised an error because routes-gen needs v4, but v4 wasn't installed. The package needs to use dependencies and not devDependencies for its required packages to be installed with it
sandulat
requested changes
Apr 14, 2022
There was a problem hiding this comment.
@itsMapleLeaf Sorry for the delay and thank you for the PR. Much appreciated.
Let's keep @types/fs-extra and config in devDependencies. As soon as we have this, I'll publish the new version asap.
|
No worries, done 🙂 |
|
Thank you very much @itsMapleLeaf! Published under v0.3.3: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had chalk v5 installed in my project, which raised an error because routes-gen needs v4, but v4 wasn't installed. The package needs to use dependencies and not devDependencies for its required packages to be installed with it