Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace source-map-js dependency #28

Open
gabidobo opened this issue Sep 2, 2022 · 0 comments
Open

Replace source-map-js dependency #28

gabidobo opened this issue Sep 2, 2022 · 0 comments
Assignees
@gabidobo
Labels
experiment

Comments

@gabidobo
Copy link
Member

gabidobo commented Sep 2, 2022 •
edited

Our current sourcemap parsing engine, source-map-js, is a fork of the original Mozilla module, but with several optimizations and without WASM.

This is not ideal because:

  • Source map processing makes up for more than 2/3 of our bundle size
  • source-map-js also bundles a generator that we don't need
  • it uses new Function() internally, which is potentially dangerous

Ideally, we should be able to internally parse sourcemaps, and remove this single dependency that Sandworm currently has.

image
@gabidobo gabidobo self-assigned this Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabidobo gabidobo

Labels
experiment
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

28-replace-source-map-js-dependency sandworm-hq/sandworm-guard-js
1 participant
@gabidobo